Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove wrong default value in buffer.md #19883

Closed
wants to merge 1 commit into from
Closed

doc: remove wrong default value in buffer.md #19883

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

It seems this is an accidental leftover from this change in e8bb1f3:

diff

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2018
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/455/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
@Trott
Copy link
Member

Trott commented Apr 9, 2018

It is unrelated, so feel free to ignore, but since you're nearby: The two previous lines are not wrapped at 80 chars. I wouldn't mind it if you did that wrapping while we're editing nearby text.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 9, 2018 •
edited
Loading

@Trott Done)
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/456/

@Trott
Copy link
Member

Trott commented Apr 9, 2018

CI Lite again: https://ci.nodejs.org/job/node-test-pull-request-lite/457/

@vsemozhetbyt
Copy link
Contributor Author

Landed in 0cd8359

@vsemozhetbyt vsemozhetbyt deleted the doc-buf-err-default branch April 9, 2018 08:56
vsemozhetbyt added a commit that referenced this pull request Apr 9, 2018
@vsemozhetbyt
doc: remove wrong default value in buffer.md
0cd8359 
PR-URL: #19883
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos added dont-land-on-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vsemozhetbyt @Trott @cjihrig @trivikr @targos @nodejs-github-bot