Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify definite Array types #19895

Closed
wants to merge 1 commit into from
Closed

doc: specify definite Array types #19895

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Replace {Array} with {type[]}.

@vsemozhetbyt
doc: specify definite Array types
2ae9cd7 
Replace `{Array}` with `{type[]}`.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/462/

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in dff2141

vsemozhetbyt added a commit that referenced this pull request Apr 9, 2018
@vsemozhetbyt
doc: specify definite Array types
dff2141 
Replace `{Array}` with `{type[]}`.

PR-URL: #19895
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-array-types branch April 9, 2018 14:06
targos pushed a commit that referenced this pull request Apr 12, 2018
@vsemozhetbyt @targos
doc: specify definite Array types
0f71149 
Replace `{Array}` with `{type[]}`.

PR-URL: #19895
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsemozhetbyt @lpinca @cjihrig @nodejs-github-bot