tools: stricter no-undef eslint rule #19926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default eslint does not validate variables that are placed in a typeof check. This caused a error that is fixed in this PR.
nodejs-github-bot
added
fs
devsnek
approved these changes
Apr 11, 2018
starkwang
approved these changes
Apr 11, 2018
BridgeAR
added
the
author ready
|
For the |
trivikr
approved these changes
Apr 12, 2018
|
@Trott I agree, I plan on landing a different PR first and I will rebase afterwards to only update the eslint rule. |
cjihrig
approved these changes
Apr 12, 2018
jasnell
approved these changes
Apr 12, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 13, 2018
By default eslint does not validate variables that are placed in a typeof check. PR-URL: nodejs#19926 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 6376d43 |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
By default eslint does not validate variables that are placed in a typeof check. PR-URL: #19926 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
By default eslint does not validate variables that are placed in a typeof check. PR-URL: nodejs#19926 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default eslint does not validate variables that are placed in a
typeof check. This caused a error that is fixed in this PR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes