build, win: opt-in openssl_no_asm if no nasm found #19943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly.
nodejs-github-bot
added
build
BUILDING.md
Outdated
| @@ -258,9 +258,9 @@ Prerequisites: | |||
| * Basic Unix tools required for some tests, | |||
| [Git for Windows](http://git-scm.com/download/win) includes Git Bash | |||
| and tools which can be included in the global `PATH`. | |||
| * **Optional** (for OpenSSL assembler modules): the [NetWide Assembler](http://www.nasm.us/), | |||
| * The [NetWide Assembler](http://www.nasm.us/), for OpenSSL assembler modules | |||
There was a problem hiding this comment.
modules if not -> modules. If not?
There was a problem hiding this comment.
Thanks. both fixed in 6d75d2b.
BUILDING.md
Outdated
| if not installed in the default location it needs to be manually added | ||
| to `PATH`. | ||
| to `PATH`. Build with openssl-no-asm option does not require this. |
There was a problem hiding this comment.
openssl-no-asm -> `openssl-no-asm`
rvagg
approved these changes
Apr 11, 2018
bnoordhuis
approved these changes
Apr 11, 2018
|
I am adding |
vsemozhetbyt
added
the
fast-track
jasnell
approved these changes
Apr 11, 2018
bzoz
approved these changes
Apr 11, 2018
shigeki
added a commit
that referenced
this pull request
Apr 12, 2018
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: #19918 PR-URL: #19943 Refs: #19930 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
|
CI is fine except susupended fedora-last-latest-x64. |
2 tasks
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: #19918 PR-URL: #19943 Refs: #19930 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
|
If I am not mistaken, this relies on a semver-major change and should therefore not be backported. I added the labels accordingly. Please fix that if I am mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of automatically falling back to openssl_no_asm with warning
if no nasm is found during build on Windows, this stops vcbuild.bat
and requires users to specify openssl_no_asm option explicitly.
Fixes #19918.
Refs #19930
CC @joaocgreis , @nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes