test: fix warning in dlopen-ping-pong/binding.cc #19966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following compiler warning is issued:
../binding.cc:26:27:
warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
const String::Utf8Value filename(args[0]);
^
This commit updates the code to use the Isolate version.
nodejs-github-bot
added
addons
node-test-commit failure looks unrelated01:47:47 Started by user Daniel Bevenius
01:47:47 [EnvInject] - Loading node environment variables.
01:47:47 Building remotely on test-digitalocean-debian9-x64-1 (debian9-64) in workspace /home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64
01:47:47 Also: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from 138.197.97.208/138.197.97.208:55430
01:47:47 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)
01:47:47 at hudson.remoting.UserResponse.retrieve(UserRequest.java:313)
01:47:47 at hudson.remoting.Channel.call(Channel.java:952)
01:47:47 at hudson.FilePath.act(FilePath.java:998)
01:47:47 at hudson.FilePath.act(FilePath.java:987)
01:47:47 at org.jenkinsci.plugins.gitclient.Git.getClient(Git.java:137)
01:47:47 at hudson.plugins.git.GitSCM.createClient(GitSCM.java:795)
01:47:47 at hudson.plugins.git.GitSCM.createClient(GitSCM.java:786)
01:47:47 at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1154)
01:47:47 at hudson.scm.SCM.checkout(SCM.java:504)
01:47:47 at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
01:47:47 at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
01:47:47 at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
01:47:47 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
01:47:47 at hudson.model.Run.execute(Run.java:1727)
01:47:47 at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
01:47:47 at hudson.model.ResourceController.execute(ResourceController.java:97)
01:47:47 at hudson.model.Executor.run(Executor.java:429)
01:47:47 java.lang.NoClassDefFoundError: Could not initialize class com.sun.proxy.$Proxy11
01:47:47 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
01:47:47 at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
01:47:47 at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
01:47:47 at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
01:47:47 at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
01:47:47 at hudson.remoting.RemoteInvocationHandler.wrap(RemoteInvocationHandler.java:165)
01:47:47 at hudson.remoting.Channel.export(Channel.java:721)
01:47:47 at hudson.remoting.Channel.export(Channel.java:685)
01:47:47 at org.jenkinsci.plugins.gitclient.LegacyCompatibleGitAPIImpl.writeReplace(LegacyCompatibleGitAPIImpl.java:198)
01:47:47 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
01:47:47 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
01:47:47 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
01:47:47 at java.lang.reflect.Method.invoke(Method.java:498)
01:47:47 at java.io.ObjectStreamClass.invokeWriteReplace(ObjectStreamClass.java:1218)
01:47:47 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1136)
01:47:47 at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
01:47:47 at hudson.remoting.UserRequest._serialize(UserRequest.java:247)
01:47:47 at hudson.remoting.UserRequest.serialize(UserRequest.java:256)
01:47:47 at hudson.remoting.UserRequest.perform(UserRequest.java:218)
01:47:47 at hudson.remoting.UserRequest.perform(UserRequest.java:53)
01:47:47 at hudson.remoting.Request$2.run(Request.java:358)
01:47:47 at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
01:47:47 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
01:47:47 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
01:47:47 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
01:47:47 at hudson.remoting.Engine$1$1.run(Engine.java:98)
01:47:47 at java.lang.Thread.run(Thread.java:748)
01:47:47 Caused: java.io.IOException: Remote call on JNLP4-connect connection from 138.197.97.208/138.197.97.208:55430 failed
01:47:47 at hudson.remoting.Channel.call(Channel.java:958)
01:47:47 at hudson.FilePath.act(FilePath.java:998)
01:47:47 Caused: java.io.IOException: remote file operation failed: /home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64 at hudson.remoting.Channel@14b2b889:JNLP4-connect connection from 138.197.97.208/138.197.97.208:55430
01:47:47 at hudson.FilePath.act(FilePath.java:1005)
01:47:47 at hudson.FilePath.act(FilePath.java:987)
01:47:47 at org.jenkinsci.plugins.gitclient.Git.getClient(Git.java:137)
01:47:47 at hudson.plugins.git.GitSCM.createClient(GitSCM.java:795)
01:47:47 at hudson.plugins.git.GitSCM.createClient(GitSCM.java:786)
01:47:47 at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1154)
01:47:47 at hudson.scm.SCM.checkout(SCM.java:504)
01:47:47 at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
01:47:47 at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
01:47:47 at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
01:47:47 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
01:47:47 at hudson.model.Run.execute(Run.java:1727)
01:47:47 at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
01:47:47 at hudson.model.ResourceController.execute(ResourceController.java:97)
01:47:47 at hudson.model.Executor.run(Executor.java:429)
01:47:47 Run condition [Always] enabling perform for step [[]]
01:47:47 Run condition [Always] enabling perform for step [[]]
01:47:47 TAP Reports Processing: START
01:47:47 Looking for TAP results report in workspace using pattern: *.tap
01:47:47 Did not find any matching files. Setting build result to FAILURE.
01:47:47 Checking ^not ok
01:47:47 Jenkins Text Finder: File set '*.tap' is empty
01:47:47 Notifying upstream projects of job completion
01:47:47 Finished: FAILURE |
cjihrig
approved these changes
Apr 12, 2018
jasnell
approved these changes
Apr 12, 2018
|
Landed in bd0a690. |
danbev
added a commit
that referenced
this pull request
Apr 14, 2018
Currently, the following compiler warning is issued:
../binding.cc:26:27:
warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
const String::Utf8Value filename(args[0]);
^
This commit updates the code to use the Isolate version.
PR-URL: #19966
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Currently, the following compiler warning is issued:
../binding.cc:26:27:
warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
const String::Utf8Value filename(args[0]);
^
This commit updates the code to use the Isolate version.
PR-URL: #19966
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Currently, the following compiler warning is issued:
../binding.cc:26:27:
warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
const String::Utf8Value filename(args[0]);
^
This commit updates the code to use the Isolate version.
PR-URL: nodejs#19966
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following compiler warning is issued:
This commit updates the code to use the Isolate version.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes