tools: fix broken link in icu notes #20030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link text and url were swapped around, this pr puts the link text inside [] and the url inside ().
nodejs-github-bot
added
i18n-api
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
added
doc
richardlau
approved these changes
Apr 14, 2018
tniessen
approved these changes
Apr 14, 2018
jasnell
approved these changes
Apr 14, 2018
trivikr
approved these changes
Apr 14, 2018
trivikr
pushed a commit
that referenced
this pull request
Apr 14, 2018
Link text and url were swapped around, this pr puts the link text inside [] and the url inside (). PR-URL: #20030 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in c1a05e5 Thanks @harrysarson for the PR and congratulations on your first commit in Node.js core! 🎉🎉🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Link text and url were swapped around, this pr puts the link text inside [] and the url inside (). PR-URL: #20030 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
srl295
reviewed
Apr 26, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Link text and url were swapped around, this pr puts the link text inside [] and the url inside (). PR-URL: nodejs#20030 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to ICU was broken in ./tools/icu/README.md, this PR fixes the link so that clicking on it takes the user to the ICU homepage.
make -j4 test(UNIX), orvcbuild test(Windows) passes