Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use v8:: namepace consistently in node_file #20059

Closed
wants to merge 1 commit into from
Closed

src: use v8:: namepace consistently in node_file #20059

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 16, 2018

Currently node_file.cc has a number of using declarations but in a few
places still uses the qualified names. This commit changes this for
consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: use v8:: namepace consistently in node_file
61564ba 
Currently node_file.cc has a number of using declarations but in a few
places still uses the qualified names. This commit changes this for
consistency.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Apr 16, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14322/

@devsnek
Copy link
Member

devsnek commented Apr 16, 2018

sidenote: i wonder if our linter script can be patched to catch stuff like this

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 18, 2018

Landed in 8384b07.

@danbev danbev closed this Apr 18, 2018
@danbev danbev deleted the node_file_using branch April 18, 2018 09:43
danbev added a commit that referenced this pull request Apr 18, 2018
@danbev
src: use v8:: namepace consistently in node_file
8384b07 
Currently node_file.cc has a number of using declarations but in a few
places still uses the qualified names. This commit changes this for
consistency.

PR-URL: #20059
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@danbev @jasnell
src: use v8:: namepace consistently in node_file
1396996 
Currently node_file.cc has a number of using declarations but in a few
places still uses the qualified names. This commit changes this for
consistency.

PR-URL: #20059
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danbev @devsnek @jasnell @addaleax @cjihrig @tniessen @BridgeAR @nodejs-github-bot