Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add ryzokuken to collaborators #20081

Closed
wants to merge 1 commit into from
Closed

doc: add ryzokuken to collaborators #20081

wants to merge 1 commit into from

Conversation

ryzokuken
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ryzokuken ryzokuken self-assigned this Apr 16, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 16, 2018
apapirovski
apapirovski approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ryzokuken ryzokuken added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 16, 2018
@ryzokuken
Copy link
Contributor Author

CI Lite: https://ci.nodejs.org/job/node-test-commit-lite/705/

ryzokuken added a commit that referenced this pull request Apr 16, 2018
@ryzokuken
doc: add ryzokuken to collaborators
fb2d9df 
PR-URL: #20081
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ryzokuken
Copy link
Contributor Author

Landed in fb2d9df 🎉

@ryzokuken ryzokuken closed this Apr 16, 2018
@addaleax addaleax mentioned this pull request Apr 16, 2018
Closed
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 16, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@ryzokuken @jasnell
doc: add ryzokuken to collaborators
0a99cb1 
PR-URL: #20081
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees

@ryzokuken ryzokuken

Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ryzokuken @apapirovski @addaleax @richardlau @Trott @nodejs-github-bot