test: fix flaky http-server-keep-alive-timeout #20093
Conversation
Make sure the connection is not closed until the 3 requests and the `timeout` event are received. Some code refactoring to avoid duplicated code. Fixes: nodejs#20013
| test(function serverEndKeepAliveTimeoutWithPipeline(cb) { | ||
| function done(server, socket, cb) { | ||
| socket.destroy(); | ||
| server.close(); |
There was a problem hiding this comment.
Nit: I'd pass the callback to close() instead of calling it explicitly.
| cb(); | ||
| } | ||
|
|
||
| function server_test(with_pipeline, cb) { |
|
Stress test on FreeBSD 10: https://ci.nodejs.org/job/node-stress-single-test/1818/ |
|
Doesn't look like it survived the stress test. 😞 Edit: I stopped the stress test since it was clearly not successful. Here are the results at that point in time: |
|
Yeah, the underlying issue seems to be that calling |
|
Stress test should be: https://ci.nodejs.org/job/node-stress-single-test/1820/ |
| server.close(cb); | ||
| } | ||
|
|
||
| function serverTest(with_pipeline, cb) { |
There was a problem hiding this comment.
Nit: there are still a couple of snake case variables. Would you mind fixing those before of when landing? Thanks.
Make sure the connection is not closed until the 3 requests and the `timeout` event are received. Some code refactoring to avoid duplicated code. Fixes: #20013 PR-URL: #20093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 998e174 with nit addressed. Thanks! |
Make sure the connection is not closed until the 3 requests and the `timeout` event are received. Some code refactoring to avoid duplicated code. Fixes: #20013 PR-URL: #20093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Make sure the connection is not closed until the 3 requests and the
timeoutevent are received.Some code refactoring to avoid duplicated code.
Fixes: #20013
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes