src: remove redundant calls to v8::HandleScope #20110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant calls to v8::HandleScope in the contructor and destructor for the AsyncScope class Refs: nodejs#19972 (comment) Refs: nodejs#20045
nodejs-github-bot
added
the
c++
|
Couldn't this just happen inside #20045 since it's so highly related? |
|
@apapirovski Makes sense. I will just push this commit to that branch. |
|
Wait, what? Blooper, this was already done in #20045 anyway. I saw two calls and didn't realize that the PR hadn't landed yet and these were the exact same calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked for #20045
Remove redundant calls to v8::HandleScope in the contructor and
destructor for the AsyncScope class
Refs: #19972 (comment)
Refs: #20045
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @hashseed @addaleax @nodejs/v8