doc: update links and names for DevTools Protocol #20111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
fast-track
|
Please, add 👍 here to approve fast-tracking. |
apapirovski
approved these changes
Apr 17, 2018
eugeneo
approved these changes
Apr 17, 2018
vsemozhetbyt
added
the
author ready
richardlau
reviewed
Apr 17, 2018
| @@ -128,7 +128,7 @@ Activate inspector on host:port. Default is 127.0.0.1:9229. | |||
|
|
|||
| V8 inspector integration allows tools such as Chrome DevTools and IDEs to debug | |||
| and profile Node.js instances. The tools attach to Node.js instances via a | |||
| tcp port and communicate using the [Chrome Debugging Protocol][]. | |||
| tcp port and communicate using the [Chrome DevTools Protocol][]. | |||
There was a problem hiding this comment.
Small nit: for consistency, also update
Lines 110 to 117 in a43e889
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/541/ |
richardlau
approved these changes
Apr 17, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 17, 2018
PR-URL: #20111 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in c98eeb6 |
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2018
PR-URL: #20111 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe old URL is now redirected to this URL.