http: _http_common.js (and associated) cleanup #20126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove constant deep property access by storing a reference, use more const, make some conditionals stricter.
A comment explaining kOnHeaders function of the parser was duplicated in two places but the second instance was more confusing than helpful.
Cleanup constructor and freeParser to manage all existing parser properties, not just some.
freeParser already unsets parser property of socket if socket is passed in specifically. There's no need to do this twice.
lpinca
approved these changes
Apr 18, 2018
danbev
approved these changes
Apr 19, 2018
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 23, 2018
Remove constant deep property access by storing a reference, use more const, make some conditionals stricter. PR-URL: nodejs#20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 23, 2018
A comment explaining kOnHeaders function of the parser was duplicated in two places but the second instance was more confusing than helpful. PR-URL: nodejs#20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 23, 2018
Cleanup constructor and freeParser to manage all existing parser properties, not just some. PR-URL: nodejs#20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 23, 2018
freeParser already unsets parser property of socket if socket is passed in specifically. There's no need to do this twice. PR-URL: nodejs#20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in 1d1ab76...54e112d 🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
Remove constant deep property access by storing a reference, use more const, make some conditionals stricter. PR-URL: #20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
A comment explaining kOnHeaders function of the parser was duplicated in two places but the second instance was more confusing than helpful. PR-URL: #20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
Cleanup constructor and freeParser to manage all existing parser properties, not just some. PR-URL: #20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
freeParser already unsets parser property of socket if socket is passed in specifically. There's no need to do this twice. PR-URL: #20126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 smaller commits here:
Remove constant deep property access by storing a reference,
use more const, make some conditionals stricter.
A comment explaining kOnHeaders function of the parser was duplicated
in two places but the second instance was more confusing than helpful.
Cleanup constructor and freeParser to manage all existing parser
properties, not just some.
freeParser already unsets parser property of socket if socket is passed
in specifically. There's no need to do this twice.
This is a part of an upcoming deep dive into cleaning up some internals of the
httpmodule.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes