Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fully document --experimental-repl-await #20133

Closed
wants to merge 1 commit into from
Closed

doc: fully document --experimental-repl-await #20133

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Apr 18, 2018 •
edited
Loading

Fixes: #19604 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 18, 2018
@TimothyGu TimothyGu mentioned this pull request Apr 18, 2018
Closed
3 tasks
@vsemozhetbyt vsemozhetbyt added the repl Issues and PRs related to the REPL subsystem. label Apr 18, 2018
@TimothyGu TimothyGu added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2018
@TimothyGu
Copy link
Member Author

I'd like to fast track this. Please 👍-react if you agree!

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/547/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 18, 2018
@vsemozhetbyt
Copy link
Contributor

This should be backported with #19604

@TimothyGu
Copy link
Member Author

Landed in ceab78f.

@TimothyGu TimothyGu closed this Apr 18, 2018
TimothyGu added a commit that referenced this pull request Apr 18, 2018
@TimothyGu
doc: fully document --experimental-repl-await
ceab78f 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu TimothyGu deleted the repl-doc branch April 18, 2018 21:13
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@TimothyGu @jasnell
doc: fully document --experimental-repl-await
56d6e82 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@TimothyGu @vsemozhetbyt @jasnell @richardlau @devsnek @ryzokuken @trivikr @nodejs-github-bot