Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove crypto.DEFAULT_ENCODING usage #20221

Closed
wants to merge 1 commit into from
Closed

test: remove crypto.DEFAULT_ENCODING usage #20221

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 23, 2018

This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
test: remove crypto.DEFAULT_ENCODING usage
44c9fc7 
This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 23, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14437/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 25, 2018

Landed in c521a20.

@danbev danbev closed this Apr 25, 2018
@danbev danbev deleted the crypto_remove_crypto.DEFAULT_ENCODING_usage branch April 25, 2018 04:20
danbev added a commit to danbev/node that referenced this pull request Apr 25, 2018
@danbev
test: remove crypto.DEFAULT_ENCODING usage
c521a20 
This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.

PR-URL: nodejs#20221
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@targos targos mentioned this pull request May 12, 2018
Closed
tniessen pushed a commit to tniessen/node that referenced this pull request May 13, 2018
@danbev @tniessen
test: remove crypto.DEFAULT_ENCODING usage
9e9dad6 
This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.

PR-URL: nodejs#20221
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessen tniessen mentioned this pull request May 13, 2018
Closed
addaleax pushed a commit that referenced this pull request May 14, 2018
@danbev @addaleax
test: remove crypto.DEFAULT_ENCODING usage
eb21a6b 
This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.

Backport-PR-URL: #20706
PR-URL: #20221
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
@targos targos added this to Backported in v10.x Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
No open projects
v10.x
  
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danbev @MylesBorins @jasnell @BridgeAR @trivikr @targos @nodejs-github-bot