Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use snake_case_ for private member dh #20245

Closed
wants to merge 1 commit into from
Closed

src: use snake_case_ for private member dh #20245

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 24, 2018

This commit renames the private member dh in the DiffieHellman class to
dh_ for consistency with CPP_STYLE_GUIDE.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: use snake_case_ for private member dh
bc7f85c 
This commit renames the private member dh in the DiffieHellman class to
dh_ for consistency with CPP_STYLE_GUIDE.md.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Apr 24, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14464/

@danbev
Copy link
Contributor Author

danbev commented Apr 24, 2018

Closing in favour of #20238 which has this change in it.

@danbev danbev closed this Apr 24, 2018
@danbev danbev deleted the crypto_diffiehellman_dh_member branch April 27, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danbev @nodejs-github-bot