Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify prerequisites in benchmark/README.md #2034

Merged

Conversation

Fishrock123
Copy link
Member

i.e. neither of these are available via apt-get, and people won't necessarily know how they might get them otherwise. (Or that "ab" stands for ApacheBench.)

@Fishrock123 Fishrock123 added doc Issues and PRs related to the documentations. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 23, 2015
@trevnorris
Copy link
Contributor

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

PR-URL: nodejs#2034
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@Fishrock123 Fishrock123 force-pushed the clarify-benchmark-prerequisites branch from d2b21c4 to dbd5dc9 Compare June 24, 2015 16:58
@Fishrock123 Fishrock123 merged commit dbd5dc9 into nodejs:master Jun 24, 2015
@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
PR-URL: nodejs#2034
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants