src: remove unnecessary copy operations in tracing code #20356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
c++
nodejs-github-bot
added
the
c++
|
CI: https://ci.nodejs.org/job/node-test-commit/18073/ Not urgent but I think fast-tracking makes sense, feel free to 👍 this comment if you do too :) |
jasnell
reviewed
Apr 27, 2018
| @@ -63,7 +63,7 @@ void NodeCategorySet::Enable(const FunctionCallbackInfo<Value>& args) { | |||
| NodeCategorySet* category_set; | |||
| ASSIGN_OR_RETURN_UNWRAP(&category_set, args.Holder()); | |||
| CHECK_NE(category_set, nullptr); | |||
| auto categories = category_set->GetCategories(); | |||
| const auto& categories = category_set->GetCategories(); | |||
There was a problem hiding this comment.
thank you, I consistently forget that the const and & are still required with auto.
jasnell
approved these changes
Apr 27, 2018
cjihrig
approved these changes
Apr 27, 2018
addaleax
added
the
author ready
apapirovski
approved these changes
Apr 28, 2018
|
Landed in 7016ee6 |
apapirovski
pushed a commit
that referenced
this pull request
Apr 28, 2018
PR-URL: #20356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes