doc: add http.ClientRequest maxHeadersCount #20361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
doc/api/http.md
Outdated
|
|
||
| * {number} **Default:** `2000` | ||
|
|
||
| Limits maximum response headers count. If set to 0 - no limit will be applied. |
There was a problem hiding this comment.
Shouldn't it be a comma instead of a hyphen ? Same for server.maxHeadersCount. Just a thought.
If set to 0, no limit will be applied.
There was a problem hiding this comment.
Thanks for your review, PTAL.
There was a problem hiding this comment.
@Trott : Can you please confirm if above is fine. Missed to cc you in the initial comment. Thanks !
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma.
|
@nodejs/http @nodejs/http2 PTAL |
Trott
approved these changes
Apr 29, 2018
trivikr
approved these changes
Apr 30, 2018
cjihrig
approved these changes
Apr 30, 2018
mithunsasidharan
approved these changes
Apr 30, 2018
Trott
added
the
author ready
|
Landed in 516349d |
trivikr
pushed a commit
that referenced
this pull request
May 3, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In http.ClientRequest's doc, add maxHeadersCount as a public property.
Refs: #20359
Checklist