Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix TypeError from test.py --time #20368

Closed
wants to merge 1 commit into from
Closed

tools: fix TypeError from test.py --time #20368

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

Fixes: #20341

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
tools: fix TypeError from test.py --time
1fcb189 
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 27, 2018
@richardlau richardlau mentioned this pull request Apr 27, 2018
Closed
@richardlau
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/14550/

@richardlau
Copy link
Member Author

CI is green (!).

@BridgeAR
Copy link
Member

@nodejs/build PTAL

@BridgeAR BridgeAR added the build Issues and PRs related to build files or the CI. label Apr 29, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2018
@trivikr
Copy link
Member

trivikr commented May 3, 2018

Landed in ab15198

@trivikr trivikr closed this May 3, 2018
trivikr pushed a commit that referenced this pull request May 3, 2018
@richardlau @trivikr
tools: fix TypeError from test.py --time
ab15198 
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

PR-URL: #20368
Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@richardlau @MylesBorins
tools: fix TypeError from test.py --time
f6d37f2 
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

PR-URL: #20368
Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@richardlau @MylesBorins
tools: fix TypeError from test.py --time
3912551 
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

PR-URL: #20368
Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@richardlau @MylesBorins
tools: fix TypeError from test.py --time
246c2d1 
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

PR-URL: #20368
Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richardlau @BridgeAR @trivikr @Trott @nodejs-github-bot