Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add eslint check for skipIfEslintMissing #20372

Merged
merged 1 commit into from
May 8, 2018
Merged

tools: add eslint check for skipIfEslintMissing #20372

merged 1 commit into from
May 8, 2018

Commits on May 8, 2018

  1. tools: add eslint check for skipIfEslintMissing 

    Add a custom eslint rule to check for `common.skipIfEslintMissing()` to
allow tests to run from source tarballs that do not include eslint.

Fix up rule tests that were failing the new check.

Refs: nodejs#20336

PR-URL: nodejs#20372
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @richardlau
    richardlau committed May 8, 2018
    Configuration menu
    Copy the full SHA
    870ae72 View commit details
    Browse the repository at this point in the history