src: remove kFlagNoShutdown flag
#20388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This was originally introduced in 3446ff4, in order to fix a hard crash. However, since the libuv 1.18.0 update, that hard crash is gone, and since f2b9805 we do not throw an error in JS land anymore either, rendering the flag unnecessary. Also, the original test that checked this condition was added to `test/parallel/`. Since that typically runs without a TTY stdin, a duplicate test is being added to the pseudo-tty test suite in this commit. Refs: nodejs@3446ff4 Refs: nodejs@f2b9805 Refs: libuv/libuv@0e28141
addaleax
force-pushed
the
no-has-shutdown-flag
branch
from
9a3c516
to
90f2f07
Compare
apapirovski
approved these changes
Apr 28, 2018
BridgeAR
approved these changes
Apr 29, 2018
addaleax
added
dont-land-on-v6.x
author ready
bnoordhuis
approved these changes
Apr 30, 2018
|
Landed in 5512fff |
addaleax
removed
the
author ready
addaleax
added a commit
that referenced
this pull request
May 3, 2018
This was originally introduced in 3446ff4, in order to fix a hard crash. However, since the libuv 1.18.0 update, that hard crash is gone, and since f2b9805 we do not throw an error in JS land anymore either, rendering the flag unnecessary. Also, the original test that checked this condition was added to `test/parallel/`. Since that typically runs without a TTY stdin, a duplicate test is being added to the pseudo-tty test suite in this commit. Refs: 3446ff4 Refs: f2b9805 Refs: libuv/libuv@0e28141 PR-URL: #20388 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This was originally introduced in 3446ff4, in order to fix a hard crash. However, since the libuv 1.18.0 update, that hard crash is gone, and since f2b9805 we do not throw an error in JS land anymore either, rendering the flag unnecessary. Also, the original test that checked this condition was added to `test/parallel/`. Since that typically runs without a TTY stdin, a duplicate test is being added to the pseudo-tty test suite in this commit. Refs: 3446ff4 Refs: f2b9805 Refs: libuv/libuv@0e28141 PR-URL: #20388 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This was originally introduced in 3446ff4, in order to fix a hard crash. However, since the libuv 1.18.0 update, that hard crash is gone, and since f2b9805 we do not throw an error in JS land anymore either, rendering the flag unnecessary. Also, the original test that checked this condition was added to `test/parallel/`. Since that typically runs without a TTY stdin, a duplicate test is being added to the pseudo-tty test suite in this commit. Refs: 3446ff4 Refs: f2b9805 Refs: libuv/libuv@0e28141 PR-URL: #20388 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally introduced in 3446ff4, in order to fix
a hard crash. However, since the libuv 1.18.0 update, that hard
crash is gone, and since f2b9805 we do not throw an
error in JS land anymore either, rendering the flag unnecessary.
Also, the original test that checked this condition was added
to
test/parallel/. Since that typically runs without a TTY stdin,a duplicate test is being added to the pseudo-tty test suite
in this commit.
Refs: 3446ff4
Refs: f2b9805
Refs: libuv/libuv@0e28141
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes