Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: document the look of napi_external values #20426

Closed
wants to merge 1 commit into from
Closed

n-api: document the look of napi_external values #20426

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Describe what JavaScript values of type napi_external look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

n-api: document the look of napi_external values
bb65a0c 
Describe what JavaScript values of type `napi_external` look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 30, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/634/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 30, 2018
mhdawson
mhdawson approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor Author

Landed in d3255ca.

gabrielschulhof pushed a commit that referenced this pull request Apr 30, 2018
n-api: document the look of napi_external values
d3255ca 
Describe what JavaScript values of type `napi_external` look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306
PR-URL: #20426
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@MylesBorins
n-api: document the look of napi_external values
1908668 
Describe what JavaScript values of type `napi_external` look like in
JavaScript.

Fixes: nodejs/abi-stable-node#306
PR-URL: #20426
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
@gabrielschulhof gabrielschulhof deleted the 306-document-external branch May 16, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that externals are frozen objects
4 participants
@gabrielschulhof @vsemozhetbyt @mhdawson @nodejs-github-bot