doc: add more missing backticks #20438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix some other nits in passing (formatting, punctuation, typos, redundancy, obsoleteness).
|
Added new commit with more backticks mostly in links. |
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
May 2, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
May 2, 2018
Also, fix some other nits in passing (formatting, punctuation, typos, redundancy, obsoleteness). PR-URL: #20438 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 7588cea |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Also, fix some other nits in passing (formatting, punctuation, typos, redundancy, obsoleteness). PR-URL: #20438 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Also, fix some other nits in passing (formatting, punctuation, typos, redundancy, obsoleteness). PR-URL: #20438 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAlso, fix some other nits in passing (formatting, punctuation, typos, redundancy, obsoleteness).
There were some dubious cases: it is not always clear if words like Object, Function, String, Error etc are used in their type/class meaning or a common meaning (even considering that I've checked only uppercased variants). I did my best guessing and sometimes just lowercased the words.
If I've overdone it somewhere, please, correct me and I will revert these cases in fixup commits.
cc @nodejs/documentation.