Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fs/promises filehandle stat test #20492

Closed

Conversation

@shisama
Copy link

shisama commented May 3, 2018

Added test for fs/promises filehandle stat.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Added test for fs/promises filehandle stat.
@cjihrig
cjihrig approved these changes May 3, 2018
@lpinca
lpinca approved these changes May 3, 2018
common.crashOnUnhandledRejection();

async function validateStat() {
const filePath = path.resolve(tmpDir, 'tmp-read-file.txt');

This comment has been minimized.

Copy link
@trivikr

trivikr May 3, 2018

Member

tmpDir is used used only once here.
Can we remove variable tmpDir and pass tmpdir.path here, so that there's no confusion between similar looking variables tmpdir and tmpDir

This comment has been minimized.

Copy link
@shisama

shisama May 4, 2018

Author

@trivikr
Thank you. I fixed it.

Masashi Hirano
@trivikr
trivikr approved these changes May 4, 2018
@trivikr

This comment has been minimized.

@jasnell
jasnell approved these changes May 4, 2018
@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented May 5, 2018

CI rerun for node-test-commit-aix https://ci.nodejs.org/job/node-test-commit-aix/14731/

@trivikr trivikr added the author ready label May 5, 2018
trivikr added a commit that referenced this pull request May 5, 2018
Added test for fs/promises filehandle stat.

PR-URL: #20492
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented May 5, 2018

Landed in f74b344

Congratulations @shisama on your first commit in Node.js core! 🎉 🎉 🎉

@trivikr trivikr closed this May 5, 2018
@ChALkeR ChALkeR added the experimental label May 8, 2018
MylesBorins added a commit that referenced this pull request May 8, 2018
Added test for fs/promises filehandle stat.

PR-URL: #20492
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
MylesBorins added a commit that referenced this pull request May 8, 2018
Added test for fs/promises filehandle stat.

PR-URL: #20492
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 9, 2018
Added test for fs/promises filehandle stat.

PR-URL: #20492
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.