REPL fixes #2052
Closed
REPL fixes #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: io.js PR-URL here Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: nodejs/node-v0.x-archive#8874 PR-URL: nodejs/node-v0.x-archive#8875 PR-URL: insert io.js PR-URL Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
LGTM if the CI is happy. I wonder if the regex in the second commit ever worked. |
|
One of the build machines had some modules where the REPL could locate them, so the New CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/78/ |
test-repl-tab-complete.js contains numerous assertions that are never run. Anything that results in a ReferenceError bails out, and never calls the functions containing the assertions. This commit adds checking for successful tab completions, as well as ReferenceErrors. PR-URL: insert here
cjihrig
pushed a commit
that referenced
this pull request
Jun 25, 2015
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: #2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
misterdjules
pushed a commit
that referenced
this pull request
Jun 25, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: nodejs/node-v0.x-archive#8874 PR-URL: nodejs/node-v0.x-archive#8875 PR-URL: #2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig
added a commit
that referenced
this pull request
Jun 25, 2015
test-repl-tab-complete.js contains numerous assertions that are never run. Anything that results in a ReferenceError bails out, and never calls the functions containing the assertions. This commit adds checking for successful tab completions, as well as ReferenceErrors. PR-URL: #2052 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: nodejs/node-v0.x-archive#8874 PR-URL: nodejs/node-v0.x-archive#8875 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
test-repl-tab-complete.js contains numerous assertions that are never run. Anything that results in a ReferenceError bails out, and never calls the functions containing the assertions. This commit adds checking for successful tab completions, as well as ReferenceErrors. PR-URL: nodejs#2052 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three commits:
test-repl-tab-complete.js, which was silently not working as expected. The test was relying on assertions that were never executed.