Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make the abbreviation 1MM clear #2053

Closed
wants to merge 1 commit into from
Closed

doc: make the abbreviation 1MM clear #2053

wants to merge 1 commit into from

Conversation

yanxyz
Copy link
Contributor

@yanxyz yanxyz commented Jun 25, 2015

change #2050

@cjihrig
Copy link
Contributor

cjihrig commented Jun 25, 2015

LGTM

1 similar comment
@Trott
Copy link
Member

Trott commented Jun 25, 2015

LGTM

@brendanashworth brendanashworth added the doc Issues and PRs related to the documentations. label Jun 25, 2015
cjihrig pushed a commit that referenced this pull request Jun 25, 2015
@yanxyz @cjihrig
doc: make the abbreviation 1MM clear
c370bd3 
Refs: #2050
PR-URL: #2053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig
Copy link
Contributor

cjihrig commented Jun 25, 2015

Thanks. Landed in c370bd3

@cjihrig cjihrig closed this Jun 25, 2015
@rvagg rvagg mentioned this pull request Jun 30, 2015
Closed
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
@yanxyz @mscdex
doc: make the abbreviation 1MM clear
17f6d69 
Refs: nodejs#2050
PR-URL: nodejs#2053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aliscco aliscco mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanxyz @cjihrig @Trott @brendanashworth