Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarification: not EventEmitter but its instance #20537

Closed
wants to merge 2 commits into from
Closed

clarification: not EventEmitter but its instance #20537

wants to merge 2 commits into from

Conversation

dagolinuxoid
Copy link
Contributor

@dagolinuxoid dagolinuxoid commented May 5, 2018 •
edited
Loading

this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter.
Maybe adding this=== myEmitter to an example down below is redundant so feel free to modify it as well or rather keep it unchanged.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@dagolinuxoid
clarification: not EventEmitter but its instance
9e9bdf7 
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter.
Maybe adding this=== myEmitter to an example down below is redundant so feel free to modify it as well or rather keep it unchanged.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels May 5, 2018
vsemozhetbyt
vsemozhetbyt reviewed May 5, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. There is a linting nit in the changes.

doc/api/events.md Outdated
ordinary listener function is called by the `EventEmitter`, the standard `this`
keyword is intentionally set to reference the `EventEmitter` to which the
ordinary listener function is called, the standard `this`
keyword is intentionally set to reference the `EventEmitter` instance to which the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be wrapped maximum at 80 characters to pass doc linting.

cjihrig
cjihrig approved these changes May 5, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter passes.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/678/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels May 7, 2018
@vsemozhetbyt
Copy link
Contributor

@dagolinuxoid Can you fix the linting issue?

@dagolinuxoid
Update events.md
911cee4 
Looking good? I bound it to 80 chars.
@dagolinuxoid
Copy link
Contributor Author

dagolinuxoid commented May 8, 2018 •
edited
Loading

@vsemozhetbyt looking good now?

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/685/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2018
vsemozhetbyt pushed a commit that referenced this pull request May 8, 2018
@dagolinuxoid @vsemozhetbyt
doc: clarify this in event listeners
2d945fd 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 2d945fd
Thank you!

@dagolinuxoid dagolinuxoid deleted the patch-1 branch May 8, 2018 12:07
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@dagolinuxoid @MylesBorins
doc: clarify this in event listeners
69a8a65 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@dagolinuxoid @MylesBorins
doc: clarify this in event listeners
9593b35 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@dagolinuxoid @MylesBorins
doc: clarify this in event listeners
e995ae5 
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos mentioned this pull request May 10, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dagolinuxoid @vsemozhetbyt @jasnell @addaleax @TimothyGu @cjihrig @trivikr @nodejs-github-bot