Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.canCreateSymLink() consistently #20540

Merged
merged 1 commit into from
May 8, 2018
Merged

test: use common.canCreateSymLink() consistently #20540

merged 1 commit into from
May 8, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 5, 2018

This commit replaces two ad hoc symlink permission tests with common.canCreateSymLink().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 5, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented May 8, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/14708/

@cjihrig
test: use common.canCreateSymLink() consistently
8e6601a 
This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().

PR-URL: nodejs#20540
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 8e6601a into nodejs:master May 8, 2018
@cjihrig cjihrig deleted the test-symlinks branch May 8, 2018 14:38
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@cjihrig @MylesBorins
test: use common.canCreateSymLink() consistently
85babad 
This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().

PR-URL: #20540
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@cjihrig @MylesBorins
test: use common.canCreateSymLink() consistently
4b2e886 
This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().

PR-URL: #20540
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@cjihrig @MylesBorins
test: use common.canCreateSymLink() consistently
b2d3db4 
This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().

PR-URL: #20540
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cjihrig @jasnell @addaleax @BridgeAR @nodejs-github-bot