test, module: current directory gets priority for local module lookup

[RakshithNM]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[addaleax]

Thanks!

[cjihrig]

Tiny nit: Can you separate the // from Current by a single space instead of two.

[mscdex]

I think the prefix should just be test: since no changes to the actual module system are being made here?

[RakshithNM]

@cjihrig yeah ok, will update

[RakshithNM]

@mscdex ah ok, now i think so too.

[trivikr]

@RakshithNM Looks like your Outlook email ID is linked with the commits, and is not registered with Github. Kindly either register it or update your Github email ID in the config by following the instructions in Step 1

If you choose the latter, you can squash the commits so that your updated Github email ID is associated with the new commit.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/14678/

[RakshithNM]

@trivikr ah yep, i have now verified my email

[Trott]

Can be fixed by whoever lands this, but IMO the commit message makes it sound like this is a functionality change when this is a test refactor. I'd propose something like this:

test: display values in AssertionErrors

In test-module-relative-lookup, change assert.strictEqual() calls so
that values are displayed when an AssertionError occurs.

[RakshithNM]

@Trott ah ok, i have ammended the commit message

[trivikr]

@RakshithNM The author hasn't been updated in the commits
Here's an answer on StackOverflow on how to update author of existing commits

[RakshithNM]

@trivikr thanks for the link, i have now updated the author.

[addaleax]

Landed in 745463a 🎉 🎉

@RakshithNM Just so you know, these merge conflicts are actually a bit of an issue – most of the time they can be ironed out while landing, but for the next PRs, using git rebase rather than git merge (or git pull --rebase rather than git pull) would help a bit :)

[RakshithNM]

@addaleax thank you :) I will keep that in mind moving forward.