zlib: reduce number of static internal methods #20674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
danbev
approved these changes
May 11, 2018
TimothyGu
approved these changes
May 11, 2018
bnoordhuis
approved these changes
May 11, 2018
src/node_zlib.cc
Outdated
| static void Error(ZCtx* ctx, const char* message) { | ||
| Environment* env = ctx->env(); | ||
|
|
||
| // TODO(addaleax): Switch to modern error system. |
There was a problem hiding this comment.
Maybe be a little more explicit what that is.
jasnell
approved these changes
May 12, 2018
There really isn’t any good reason for these to be static methods, it just adds one layer of indirection (when reading the code, not in a way that affects behaviour). Addresses a `TODO` comment introduced in c072057. Refs: nodejs@c072057
addaleax
force-pushed
the
zlib-less-static
branch
from
80e70c6
to
2e92688
Compare
addaleax
added
the
author ready
|
Landed in 2b8cd93 |
apapirovski
pushed a commit
that referenced
this pull request
May 16, 2018
There really isn’t any good reason for these to be static methods, it just adds one layer of indirection (when reading the code, not in a way that affects behaviour). Addresses a `TODO` comment introduced in c072057. PR-URL: #20674 Refs: c072057 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
There really isn’t any good reason for these to be static methods, it just adds one layer of indirection (when reading the code, not in a way that affects behaviour). Addresses a `TODO` comment introduced in c072057. PR-URL: #20674 Refs: c072057 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There really isn’t any good reason for these to be static methods,
it just adds one layer of indirection (when reading the code,
not in a way that affects behaviour).
Addresses a
TODOcomment introduced in c072057.Refs: c072057
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes