Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: modernize and correct test-doctool-html.js #20676

Closed
wants to merge 1 commit into from
Closed

test: modernize and correct test-doctool-html.js #20676

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented May 11, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  1. Use destructuring when it is appropriate.
  2. Correct nits in comments.
  3. Reduce unneeded wrapping with string concatenations when it is cheap diff-wise.
  4. Diverge similar variables by renaming one of them.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels May 11, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/699/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. refactor to ES6+ labels May 11, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 14, 2018 •
edited
Loading

As #20613 landed, rerun CI-lite just in case:
https://ci.nodejs.org/job/node-test-pull-request-lite/704/ (green).

@vsemozhetbyt
Copy link
Contributor Author

Landed in fb93984
Thank you for the reviews.

vsemozhetbyt added a commit that referenced this pull request May 14, 2018
@vsemozhetbyt
test: modernize and correct test-doctool-html.js
fb93984 
PR-URL: #20676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt vsemozhetbyt deleted the test-doctool-html branch May 14, 2018 16:23
addaleax pushed a commit that referenced this pull request May 14, 2018
@vsemozhetbyt @addaleax
test: modernize and correct test-doctool-html.js
2a7c863 
PR-URL: #20676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vsemozhetbyt @jasnell @lpinca @BridgeAR @trivikr @nodejs-github-bot