Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable colors in test-assert.js #20695

Merged
merged 3 commits into from
May 15, 2018
Merged

test: disable colors in test-assert.js #20695

merged 3 commits into from
May 15, 2018

Commits on May 15, 2018

  1. test: disable colors in test-assert.js 

    When test/parallel/test-assert.js is run with a TTY as stdout,
color codes in assertion messages cause the test to fail. This
commit disables colors when stdout is a TTY.

Fixes: nodejs#18967
PR-URL: nodejs#20695
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed May 15, 2018
    Configuration menu
    Copy the full SHA
    b570485 View commit details
    Browse the repository at this point in the history

  2. test: disable colors in test-assert-deep.js 

    When test/parallel/test-assert-deep.js is run with a TTY as
stdout, color codes in assertion messages cause the test to fail.
This commit disables colors when stdout is a TTY.

PR-URL: nodejs#20695
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed May 15, 2018
    Configuration menu
    Copy the full SHA
    7597d45 View commit details
    Browse the repository at this point in the history

  3. test: disable colors in test-assert-checktag.js 

    When test/parallel/test-assert-checktag.js is run with a TTY
as stdout, color codes in assertion messages cause the test to
fail. This commit disables colors when stdout is a TTY.

PR-URL: nodejs#20695
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed May 15, 2018
    Configuration menu
    Copy the full SHA
    ee2a770 View commit details
    Browse the repository at this point in the history