Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve specificity in CODEOWNERS #20729

Closed
wants to merge 1 commit into from
Closed

doc: improve specificity in CODEOWNERS #20729

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 14, 2018 •
edited
Loading

Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.

Ref: #20717 (comment)

@richardlau

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 14, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott
Copy link
Member Author

Trott commented May 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/707/

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 14, 2018
@vsemozhetbyt
Copy link
Contributor

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@Trott
Copy link
Member Author

Trott commented May 15, 2018

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

@Trott
Copy link
Member Author

Trott commented May 15, 2018

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

It also means we may want to reduce the number of entries in CODEOWNERS.

@targos
Copy link
Member

targos commented May 15, 2018

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

That's true but I don't think this PR will fix it alone. According to the documentation, those teams cannot be cc'd for review because they do not have write access to the repository.

@apapirovski
Copy link
Member

@Trott same here, also needs a rebase before landing.

@Trott
doc: improve specificity in CODEOWNERS
3de0a5f 
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.
@Trott
Copy link
Member Author

Trott commented May 16, 2018

@apapirovski Rebased.

@Trott
Copy link
Member Author

Trott commented May 16, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/716/

@Trott
Copy link
Member Author

Trott commented May 16, 2018

Landed in 67463ad

@Trott Trott closed this May 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 16, 2018
@Trott
doc: improve specificity in CODEOWNERS
67463ad 
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.

PR-URL: nodejs#20729
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@Trott @MylesBorins
doc: improve specificity in CODEOWNERS
7943449 
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.

PR-URL: #20729
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
@Trott Trott deleted the fix-codeowners branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@maclover7 maclover7 maclover7 approved these changes

@hiroppy hiroppy hiroppy approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet