tls: move convertNPNProtocols to End-of-Life #20736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was deprecated in 10.0.0 because NPN support was removed. It does not make sense to keep this around longer than 10.x
jasnell
added
semver-major
|
@nodejs/crypto |
Trott
approved these changes
May 15, 2018
cjihrig
approved these changes
May 15, 2018
danbev
approved these changes
May 15, 2018
hiroppy
approved these changes
May 15, 2018
bnoordhuis
approved these changes
May 15, 2018
tniessen
approved these changes
May 15, 2018
targos
approved these changes
May 15, 2018
BridgeAR
approved these changes
May 15, 2018
|
CI https://ci.nodejs.org/job/node-test-pull-request/14878/ @ all former reviewers and James: please start the CI when opening a PR / when giving a LG :-) |
BridgeAR
added
the
author ready
|
CI looks good overall, AIX build bot failed, running again to be safe: https://ci.nodejs.org/job/node-test-commit-aix/15007/ |
trivikr
approved these changes
May 15, 2018
|
@nodejs/build @nodejs/platform-aix ... The AIX build bot is failing with a compiler error. |
ofrobots
approved these changes
May 15, 2018
|
AIX build issue was fixed by @mhdawson (or at least he reported it was fixed if he didn't fix it himself) so re-running now: https://ci.nodejs.org/job/node-test-commit-aix/15025/ |
jasnell
added a commit
that referenced
this pull request
May 17, 2018
This was deprecated in 10.0.0 because NPN support was removed. It does not make sense to keep this around longer than 10.x PR-URL: #20736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
|
Landed in 4d00cd4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated in 10.0.0 because NPN support was removed.
It does not make sense to keep this around longer than 10.x
/cc @bnoordhuis
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes