-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: move convertNPNProtocols to End-of-Life #20736
Conversation
This was deprecated in 10.0.0 because NPN support was removed. It does not make sense to keep this around longer than 10.x
@nodejs/crypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI https://ci.nodejs.org/job/node-test-pull-request/14878/ @ all former reviewers and James: please start the CI when opening a PR / when giving a LG :-) |
CI looks good overall, AIX build bot failed, running again to be safe: https://ci.nodejs.org/job/node-test-commit-aix/15007/ |
@nodejs/build @nodejs/platform-aix ... The AIX build bot is failing with a compiler error. |
AIX build issue was fixed by @mhdawson (or at least he reported it was fixed if he didn't fix it himself) so re-running now: https://ci.nodejs.org/job/node-test-commit-aix/15025/ |
This was deprecated in 10.0.0 because NPN support was removed. It does not make sense to keep this around longer than 10.x PR-URL: #20736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Landed in 4d00cd4 |
This was deprecated in 10.0.0 because NPN support was removed.
It does not make sense to keep this around longer than 10.x
/cc @bnoordhuis
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes