Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.6.346.32 #20748

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.6.346.32 #20748

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Member

Refs: v8/v8@6.6.346.31...6.6.346.32

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 15, 2018
@MylesBorins
Copy link
Member Author

Ci: https://ci.nodejs.org/job/node-test-pull-request/14887/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1370/

@MylesBorins MylesBorins requested a review from targos May 15, 2018 16:23
@bricss bricss mentioned this pull request May 17, 2018
Merged
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 18, 2018
@MylesBorins @BridgeAR
deps: patch V8 to 6.6.346.32
3424f71 
PR-URL: nodejs#20748
Refs: v8/v8@6.6.346.31...6.6.346.32
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR
Copy link
Member

Landed in 3424f71 🎉

@BridgeAR BridgeAR closed this May 18, 2018
MylesBorins added a commit that referenced this pull request May 22, 2018
@MylesBorins
deps: patch V8 to 6.6.346.32
8e058d5 
PR-URL: #20748
Refs: v8/v8@6.6.346.31...6.6.346.32
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MylesBorins @BridgeAR @jasnell @targos @cjihrig @devsnek @nodejs-github-bot