build: use nyc's merge command #20760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
CC: @addaleax |
|
s/user/use/ in commit message? |
|
Subsystem is probably |
a 'merge' command has recently been added to nyc, eliminating the need for the istanbul-merge library.
bcoe
force-pushed
the
coverage-improvements
branch
from
ae7e2a6
to
9d9c17a
Compare
cjihrig
approved these changes
May 16, 2018
BridgeAR
approved these changes
May 18, 2018
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 18, 2018
a 'merge' command has recently been added to nyc, eliminating the need for the istanbul-merge library. PR-URL: nodejs#20760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in d5a117c 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
a 'merge' command has recently been added to nyc, eliminating the need for the istanbul-merge library. PR-URL: #20760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a 'merge' command has recently been added to nyc, eliminating the need
for the istanbul-merge library.
both nyc and istanbul-merge rely on istanbul-lib-coverage, using nyc to perform the merge will ensure the same library version is used for instrumenting coverage and merging reports.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes