perf_hooks: always set bootstrapComplete #20768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
the
perf_hooks
|
build bot failed on plinux... trying again: https://ci.nodejs.org/job/node-test-commit-plinux/17698/ |
BridgeAR
approved these changes
May 18, 2018
BridgeAR
added
the
author ready
|
This needs to be rebased. |
tniessen
removed
the
author ready
cjihrig
approved these changes
May 18, 2018
jasnell
force-pushed
the
fix-bootstrapcomplete-perf
branch
from
8d59213
to
ef376ed
Compare
jasnell
added a commit
that referenced
this pull request
May 19, 2018
PR-URL: #20768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 456a819 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
performance.nodeTiming.bootstrapCompletemilestone was not always being set. It should be set immediately before the main user-code is run.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes