New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-zlib.zlib-binding.deflate as flaky #20935

Closed
wants to merge 1 commit into
base: master
from

Conversation

@mmarchini
Member

mmarchini commented May 24, 2018

test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: #20907

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: #20907
@mmarchini

This comment has been minimized.

Member

mmarchini commented May 24, 2018

Please leave a 👍 if you agree this PR should be fast-tracked.

@mmarchini

This comment has been minimized.

@apapirovski

LGTM. Is linuxone the same as linux for the purposes of these status files?

@mmarchini

This comment has been minimized.

Member

mmarchini commented May 24, 2018

Is linuxone the same as linux for the purposes of these status files

Not sure, I was thinking the same thing while making this PR. Maybe someone from @nodejs/build can answer that?

@maclover7

This comment has been minimized.

Member

maclover7 commented May 24, 2018

Is linuxone the same as linux for the purposes of these status files

I believe so, yes

@apapirovski

This comment has been minimized.

Member

apapirovski commented May 24, 2018

@nodejs/collaborators please have a look and also 👍 above to approve the fast-tracking. This way we can get the CI green / yellow again.

@richardlau

This comment has been minimized.

Member

richardlau commented May 24, 2018

Is linuxone the same as linux for the purposes of these status files

Yes, linuxone is Linux on z/Architecture (arch==s390x).

@mmarchini

This comment has been minimized.

Member

mmarchini commented May 24, 2018

Landing

@mmarchini

This comment has been minimized.

Member

mmarchini commented May 24, 2018

Landed in f96ef55

@mmarchini mmarchini closed this May 24, 2018

mmarchini added a commit that referenced this pull request May 24, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: #20907

PR-URL: #20935
Refs: #20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins added a commit that referenced this pull request May 24, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: #20907

PR-URL: #20935
Refs: #20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 24, 2018

Merged

v10.2.1 proposal #20943

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: nodejs#20907

PR-URL: nodejs#20935
Refs: nodejs#20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment