http: fix res emit close before user finish #20941
Conversation
|
Another possible solution is to use |
|
@ronag Thanks for the quick fix :) |
|
This is def urgent for a 10.2.1 - without this fix end-of-stream, pump and most userland stream stuff using those are broken when using http streams |
lib/_http_server.js
Outdated
| @@ -562,7 +562,7 @@ function resOnFinish(req, res, socket, state, server) { | |||
|
|
|||
| res.detachSocket(socket); | |||
| req.emit('close'); | |||
| res.emit('close'); | |||
| process.nextTick(emitCloseNT.bind(res)); | |||
There was a problem hiding this comment.
You could also do process.nextTick(emitCloseNT, res) to avoid the bind and accept res as an arg in your emitCloseNT function
|
/cc @MylesBorins |
|
+1 to fast tracking. |
| res.on('finish', common.mustCall((() => { | ||
| assert.strictEqual(resClosed, false); | ||
| }))); | ||
| res.on('close', common.mustCall((() => { |
There was a problem hiding this comment.
you have an unneeded paran around the arrow fn here which the linter complains about
There was a problem hiding this comment.
if everything else is green I'll go ahead and fix that while landing
ronag
force-pushed
the
fix-http-req-res-close-state
branch
from
0119e3a
to
a07ea85
Compare
|
Fixed comments. |
|
The other fix for 10.2.1 has been landed. As soon as this one lands we should be ready to go for 10.2.1 |
|
Kicked off another CI based on new changes |
| }))); | ||
| res.on('close', common.mustCall(() => { | ||
| resClosed = true; | ||
| // assert.strictEqual(res._writableState.ended, true); |
|
The failures on arm will all infra related. I've fixed the linting error and removed comment when landing. landed in 8ce20af |
PR-URL: #20941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #20941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Thanks everyone |
Changes introduced in: nodejs/node#20941 nodejs/node#20611
Fixes a regression caused by #20611 which breaks
eos,pumpandpumpify.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes