doc: move upstream information to onboarding doc #21029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclover7
approved these changes
May 30, 2018
vsemozhetbyt
approved these changes
May 30, 2018
vsemozhetbyt
added
meta
jasnell
approved these changes
May 30, 2018
lpinca
approved these changes
May 30, 2018
trivikr
approved these changes
May 31, 2018
|
@Trott sorry, this now needs rebase after the other change landed. Could you rebase? (Guessing you'll probably just land yourself at this point.) |
Move information about setting `upstream` remote and updating from `upstream` out of `onboarding-extras` and into `onboarding`. Previously, a link was provided in `onboarding` to the section. This puts all the git setup information for Collaborator onboardings in one place.
|
Landed in dce6d53 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2018
Move information about setting `upstream` remote and updating from `upstream` out of `onboarding-extras` and into `onboarding`. Previously, a link was provided in `onboarding` to the section. This puts all the git setup information for Collaborator onboardings in one place. PR-URL: nodejs#21029 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
Move information about setting `upstream` remote and updating from `upstream` out of `onboarding-extras` and into `onboarding`. Previously, a link was provided in `onboarding` to the section. This puts all the git setup information for Collaborator onboardings in one place. PR-URL: #21029 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move information about setting
upstreamremote and updating fromupstreamout ofonboarding-extrasand intoonboarding. Previously,a link was provided in
onboardingto the section. This puts all thegit setup information for Collaborator onboardings in one place.
Checklist