Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed extra requires #21069

Closed
wants to merge 2 commits into from
Closed

Removed extra requires #21069

wants to merge 2 commits into from

Conversation

ErnestoSalazar
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added https Issues or PRs related to the https subsystem. zlib Issues and PRs related to the zlib subsystem. labels May 31, 2018
BridgeAR
BridgeAR approved these changes May 31, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request-lite/779/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2018
Trott
Trott approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trott
Copy link
Member

Trott commented Jun 1, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15204/

@nodejs nodejs deleted a comment from refack Jun 1, 2018
@Trott
Copy link
Member

Trott commented Jun 1, 2018

Lone CI failure is a known flaky test being actively worked on. Here's a re-run: https://ci.nodejs.org/job/node-test-commit-linux-containered/4871/

@Trott
Copy link
Member

Trott commented Jun 3, 2018

linux-containered re-run: https://ci.nodejs.org/job/node-test-commit-linux-containered/4903/

@ErnestoSalazar
Copy link
Contributor Author

ErnestoSalazar commented Jun 5, 2018 •
edited
Loading

so, how should we proceed with this PR? :o

Trott pushed a commit to Trott/io.js that referenced this pull request Jun 6, 2018
@ErnestoSalazar @Trott
https: removed extra _http_server require
5ebdce2 
PR-URL: nodejs#21069
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 6, 2018
@ErnestoSalazar @Trott
zlib: removed extra util require
1c8f760 
PR-URL: nodejs#21069
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 6, 2018

Landed in d0943bc...1c8f760

Thanks for the contribution! 🎉

@Trott Trott closed this Jun 6, 2018
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@ErnestoSalazar @MylesBorins
https: removed extra _http_server require
1d22254 
PR-URL: #21069
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@ErnestoSalazar @MylesBorins
zlib: removed extra util require
48aa4c3 
PR-URL: #21069
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@kfarnung kfarnung kfarnung approved these changes

@lpinca lpinca lpinca approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. https Issues or PRs related to the https subsystem. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ErnestoSalazar @BridgeAR @Trott @danbev @jasnell @kfarnung @lpinca @maclover7 @trivikr @nodejs-github-bot