test: add source for test.wasm #21082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original commit 74e7a4a ("test: add basic WebAssembly test") references the source for test.wasm and while there are tools to go from wasm to wat but having the source viewable is helpful I think.
jasnell
approved these changes
Jun 1, 2018
TimothyGu
approved these changes
Jun 1, 2018
lance
approved these changes
Jun 1, 2018
lpinca
approved these changes
Jun 1, 2018
devsnek
approved these changes
Jun 1, 2018
trivikr
approved these changes
Jun 3, 2018
jdalton
approved these changes
Jun 4, 2018
node-test-commit-linux failure looks unrelatedora-latest-x64/out/Debug/obj.host/icutools/deps/icu-small/source/common/rbbirb.o.d: Permission denied
09:46:30 warning: failed to remove out/Debug/.deps/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora-latest-x64/out/Debug/obj.host/icutools/deps/icu-small/source/common/locmap.o.d: Permission denied
09:46:30 warning: failed to remove out/Debug/.deps/home/iojs/build/workspace/node-test-commit-li |
|
I think it might be infra related? @nodejs/build? @Trott? |
|
Landed in 898609e. |
danbev
added a commit
that referenced
this pull request
Jun 4, 2018
The original commit 74e7a4a ("test: add basic WebAssembly test") references the source for test.wasm and while there are tools to go from wasm to wat but having the source viewable is helpful I think. PR-URL: #21082 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
The original commit 74e7a4a ("test: add basic WebAssembly test") references the source for test.wasm and while there are tools to go from wasm to wat but having the source viewable is helpful I think. PR-URL: #21082 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original commit 74e7a4a
("test: add basic WebAssembly test") references the source for
test.wasm and while there are tools to go from wasm to wat but
having the source viewable is helpful I think.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes