src: store pointer to Environment on DestroyParam #21099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a potential segfault when inside WeakCallback, store a reference to Environment inside DestroyParam. Co-authored-by: Yang Guo <yangguo@chromium.org> Co-authored-by: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
added
the
c++
hashseed
approved these changes
Jun 2, 2018
addaleax
approved these changes
Jun 2, 2018
src/async_wrap.cc
Outdated
| @@ -426,6 +426,7 @@ static void RegisterDestroyHook(const FunctionCallbackInfo<Value>& args) { | |||
| Isolate* isolate = args.GetIsolate(); | |||
| DestroyParam* p = new DestroyParam(); | |||
| p->asyncId = args[1].As<Number>()->Value(); | |||
| p->env = Environment::GetCurrent(isolate); | |||
jasnell
approved these changes
Jun 3, 2018
TimothyGu
approved these changes
Jun 3, 2018
|
Landed in 0300f7c |
apapirovski
added a commit
that referenced
this pull request
Jun 5, 2018
To avoid a potential segfault when inside WeakCallback, store a reference to Environment inside DestroyParam. PR-URL: #21099 Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Co-authored-by: Yang Guo <yangguo@chromium.org> Co-authored-by: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
To avoid a potential segfault when inside WeakCallback, store a reference to Environment inside DestroyParam. PR-URL: #21099 Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Co-authored-by: Yang Guo <yangguo@chromium.org> Co-authored-by: Michaël Zasso <targos@protonmail.com>
Merged
|
@apapirovski Could you backport this to v8.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a potential segfault when inside
WeakCallback, store a reference toEnvironmentinsideDestroyParam. (Talk to @hashseed for more info.)Without this patch,
nodewill fail on one of our tests when run asnode --stress-compaction test/parallel/test-async-hooks-recursive-stack.js.Co-authored-by: Yang Guo yangguo@chromium.org
Co-authored-by: Michaël Zasso targos@protonmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes