test: update test-dns error message #21116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-dns is in the internet suite and therefore is rarely run. (That will change soon. We will run internet tests nightly in CI.) Because it is infrequently run, it was not noticed that it no longer passes. (An error message has changed to provide more information.) This change fixes the test so it passes.
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/803/ (Used Lite Ci because internet tests are not run in regular CI, so we're really just linting.) Custom Suites CI (which runs internet tests): https://ci.nodejs.org/job/node-test-commit-custom-suites/7/ The Custom Suites CI has two other tests failing (dgram tests) that need to be reviewed. Their failures should be ignored for this PR. |
|
👍 here for fast-tracking |
apapirovski
approved these changes
Jun 3, 2018
richardlau
approved these changes
Jun 3, 2018
trivikr
approved these changes
Jun 3, 2018
|
Landed in 60eeba4 |
addaleax
pushed a commit
that referenced
this pull request
Jun 3, 2018
test-dns is in the internet suite and therefore is rarely run. (That will change soon. We will run internet tests nightly in CI.) Because it is infrequently run, it was not noticed that it no longer passes. (An error message has changed to provide more information.) This change fixes the test so it passes. PR-URL: #21116 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
test-dns is in the internet suite and therefore is rarely run. (That will change soon. We will run internet tests nightly in CI.) Because it is infrequently run, it was not noticed that it no longer passes. (An error message has changed to provide more information.) This change fixes the test so it passes. PR-URL: #21116 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-dns is in the internet suite and therefore is rarely run. (That
will change soon. We will run internet tests nightly in CI.) Because it
is infrequently run, it was not noticed that it no longer passes. (An
error message has changed to provide more information.) This change
fixes the test so it passes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes