Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add native debugging code to workers #21423

Closed
wants to merge 1 commit into from
Closed

src: add native debugging code to workers #21423

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Now that we have better native debugging utilities in core,
let’s use them :)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: add native debugging code to workers
9ee529e 
Now that we have better native debugging utilities in core,
let’s use them :)
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/105/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 20, 2018
@addaleax
Copy link
Member Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15534/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2018
@targos
Copy link
Member

targos commented Jun 24, 2018

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/15580/

@apapirovski
Copy link
Member

Landed in 018d618

apapirovski pushed a commit that referenced this pull request Jun 25, 2018
@addaleax @apapirovski
src: add native debugging code to workers
018d618 
Now that we have better native debugging utilities in core,
let’s use them :)

PR-URL: #21423
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos pushed a commit that referenced this pull request Jun 25, 2018
@addaleax @targos
src: add native debugging code to workers
54227ee 
Now that we have better native debugging utilities in core,
let’s use them :)

PR-URL: #21423
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mmarchini mmarchini mmarchini approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@addaleax @nodejs-github-bot @targos @apapirovski @jasnell @TimothyGu @cjihrig @mmarchini @devsnek @BridgeAR