Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated worker-threads.md to include --experimental-worker flag #21461

Closed
wants to merge 1 commit into from
Closed

Updated worker-threads.md to include --experimental-worker flag #21461

wants to merge 1 commit into from

Conversation

jsmrcaga
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 22, 2018
addaleax
addaleax approved these changes Jun 22, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@addaleax addaleax added worker Issues and PRs related to Worker support. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 22, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/888/

Node collaborators, 👍 if you agree with fast-tracking this.

@Fishrock123
Copy link
Member

Can this please also be added to cli.md and node.1? 😄

@vsemozhetbyt
Copy link
Contributor

So should we land this as is or wait for cli.md and node.1 updates?

@jsmrcaga
doc: Updated various doc files to include --experimental-worker flag
9622501 
Updated worker-threads.md, cli.md and node.1 to include --experimental-worker flag
@jsmrcaga
Copy link
Contributor Author

Hi everyone, updated cli.md and node.1 . Have never used mdoc files, so tell me if anything is wrong!

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jun 24, 2018
Closed
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 25, 2018 •
edited
Loading

@nodejs/documentation If there are no objections re the last commit, let's land tomorrow?

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/896/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 26, 2018
@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 26, 2018
@addaleax
Copy link
Member

Landed in 467a307, thanks for the PR! 🎉

@addaleax addaleax closed this Jun 26, 2018
addaleax pushed a commit that referenced this pull request Jun 26, 2018
@jsmrcaga @addaleax
doc: updated docs to include --experimental-worker flag
467a307 
Updated worker-threads.md, cli.md and node.1 to include
--experimental-worker flag

PR-URL: #21461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Jun 28, 2018
@jsmrcaga @targos
doc: updated docs to include --experimental-worker flag
511d610 
Updated worker-threads.md, cli.md and node.1 to include
--experimental-worker flag

PR-URL: #21461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet