repl: make own properties shadow prototype properties #21588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the code displayed properties backwards (e.g., showing prototype properties before own properties). It also did uniqueness checks during this processing, so these checks were done backwards. After this change, the properties continue to be displayed backwards, but the uniqueness checks are done in the proper order. Fixes: nodejs#15199 See also: nodejs#21586 which was discovered during the testing of this fix.
|
@nodejs/repl |
jasnell
approved these changes
Jun 29, 2018
TimothyGu
approved these changes
Jun 30, 2018
Trott
added
the
author ready
|
CI appears to have failed across the board on this one but the results are no longer accessible. Trying again: https://ci.nodejs.org/job/node-test-pull-request/15831/ |
|
One seemingly unrelated failure on macOS 10.12. Used "Resume Build" to re-run just that in CI: https://ci.nodejs.org/job/node-test-pull-request/15835/ Also opened an issue to track the failure in case it gets seen elsewhere: #21781 |
addaleax
approved these changes
Jul 13, 2018
|
Landed in 4d42083, thanks for the PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 13, 2018
Previously, the code displayed properties backwards (e.g., showing prototype properties before own properties). It also did uniqueness checks during this processing, so these checks were done backwards. After this change, the properties continue to be displayed backwards, but the uniqueness checks are done in the proper order. See also: #21586 which was discovered during the testing of this fix. Fixes: #15199 PR-URL: #21588 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
Previously, the code displayed properties backwards (e.g., showing prototype properties before own properties). It also did uniqueness checks during this processing, so these checks were done backwards. After this change, the properties continue to be displayed backwards, but the uniqueness checks are done in the proper order. See also: #21586 which was discovered during the testing of this fix. Fixes: #15199 PR-URL: #21588 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code displayed properties backwards (e.g., showing prototype
properties before own properties). It also did uniqueness checks during this
processing, so these checks were done backwards.
After this change, the properties continue to be displayed backwards, but
the uniqueness checks are done in the proper order.
Fixes: #15199
See also: #21586 which was discovered
during the testing of this fix.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes