doc: fix module.children description #21672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the module.children description in the docs to match current functionality in that it will only contain the modules required for the first time by this module. Fixes: nodejs#9371
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jul 5, 2018
maclover7
approved these changes
Jul 10, 2018
maclover7
added
the
author ready
jasnell
approved these changes
Jul 10, 2018
|
Landed in 98117a8 馃帀 |
addaleax
pushed a commit
that referenced
this pull request
Jul 10, 2018
Updates the module.children description in the docs to match current functionality in that it will only contain the modules required for the first time by this module. Fixes: #9371 PR-URL: #21672 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
Updates the module.children description in the docs to match current functionality in that it will only contain the modules required for the first time by this module. Fixes: #9371 PR-URL: #21672 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the module.children description in the docs to match current
functionality in that it will only contain the modules required for the
first time by this module.
Fixes: #9371
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNote: This is my first contribution to Node.js, and I chose a small issue with the good-first-issue tag. I tried to follow all of the guidelines 馃挴