stream: name anonymous function in _stream_writable.js #21753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
jasnell
approved these changes
Jul 11, 2018
trivikr
approved these changes
Jul 11, 2018
|
Thank you @mariotsi for raising your first PR in Node.js core! 🎉 |
addaleax
approved these changes
Jul 11, 2018
lpinca
approved these changes
Jul 12, 2018
lib/_stream_writable.js
Outdated
| @@ -190,7 +190,7 @@ if (typeof Symbol === 'function' && Symbol.hasInstance) { | |||
| } | |||
| }); | |||
| } else { | |||
| realHasInstance = function(object) { | |||
| realHasInstance = function realHasInstance(object) { | |||
There was a problem hiding this comment.
This is not needed, the name is inferred from the variable name.
mariotsi
force-pushed
the
anonymous-functions
branch
2 times, most recently
from
6022077
to
99f0f13
Compare
mariotsi
force-pushed
the
anonymous-functions
branch
from
99f0f13
to
6e836af
Compare
BridgeAR
added
the
author ready
BridgeAR
approved these changes
Jul 12, 2018
|
@BridgeAR just checking the meaning of the "author ready" and I'm wondering what LG stands for |
|
author-ready label is used for PRs that can land (details) |
cjihrig
approved these changes
Jul 16, 2018
|
@maclover7 one task if the CI is running from two days. |
|
Linter only needs a re-run. I'm unable to restart it right now for some reason. |
|
node-test-linter re-run https://ci.nodejs.org/job/node-test-linter/20693/ |
|
Linter CI https://ci.nodejs.org/job/node-test-linter/20702/ ✔️ [edit] I should refresh next time ;-) [/edit] |
|
I still see node-test-commit running from 3 days |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jul 18, 2018
PR-URL: nodejs#21753 Refs: nodejs#8913 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 19, 2018
PR-URL: #21753 Refs: #8913 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks :) See you on the next PR! |
targos
removed
the
author ready
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8913
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes