Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: named anonymous functions in readline.js #21759

Closed
wants to merge 1 commit into from
Closed

readline: named anonymous functions in readline.js #21759

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2018

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jul 11, 2018
@trivikr
Copy link
Member

trivikr commented Jul 11, 2018

Thank you @justdanz for your first PR in Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15803/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2018
Trott
Trott requested changes Jul 12, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be the bearer of bad news, but I think it was concluded that naming stuff on the prototype was undesirable.

@Trott
Copy link
Member

Trott commented Jul 12, 2018

@justdanz I think if you name the callback on line 846, that would be 👍.

@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@trivikr
Copy link
Member

trivikr commented Jul 18, 2018

@justdanz Can you please address comments of @Trott and update the PR by following these steps?

@maclover7 maclover7 added the wip Issues and PRs that are still a work in progress. label Jul 20, 2018
@maclover7
Copy link
Contributor

@justdanz Thank you for the PR! Closing due to inactivity. If you'd like to come back this, just reopen or leave a comment here. Please feel free to ask for any help you need in getting this over the finish line.

@maclover7 maclover7 closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@trivikr @Trott @maclover7 @jasnell @nodejs-github-bot @danweiss90